Claudenw commented on PR #406:
URL: 
https://github.com/apache/commons-collections/pull/406#issuecomment-1664384896

   > Can you try and update the PR so that the git history is kept for two of 
the renamed files. You should be able to restore the files from an old commit, 
use `git mv` to rename them and then replace the contents with the new code 
files you have here.
   > 
   > Please remove changes to IndexFilter. They may be useful. They are not 
related to this change.
   
   No luck trying to get the move to be recognized.  Tried restoring and 
moving, restoring editing and then moving, restoring clearing the git cache of 
the new name, moving.  Nothing I tried resulted in the  github display showing 
the file as changed.  Only deleted and new.
   
   If I revert the IndexFilter change the code coverage will not be 100% and no 
way to get to 100%.  If that is the better solution at this point I will do 
that and make the change later as a separate pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to