Claudenw commented on code in PR #406:
URL:
https://github.com/apache/commons-collections/pull/406#discussion_r1283555852
##########
src/main/java/org/apache/commons/collections4/bloomfilter/IndexProducer.java:
##########
@@ -117,11 +120,60 @@ public boolean test(long word) {
* @return An int array of the data.
*/
default int[] asIndexArray() {
- final BitSet result = new BitSet();
+ class Indices {
+ private int[] data = new int[32];
+ private int size;
+
+ boolean add(final int index) {
+ if (size == data.length) {
+ data = Arrays.copyOf(data, (int) Math.min(MAX_ARRAY_SIZE,
size * 2L));
+ }
+ data[size++] = index;
+ return true;
+ }
+
+ int[] toArray() {
+ // Edge case to avoid a large array copy
+ return size == data.length ? data : Arrays.copyOf(data, size);
+ }
+ }
+ Indices indices = new Indices();
+ forEachIndex(indices::add);
+ return indices.toArray();
+ }
+
+ /**
+ * Creates an IndexProducer of unique indices for this index.
+ *
+ * <p>This is like the `indices(Shape)` method except that it adds the
guarantee that no
Review Comment:
fixed and adde more info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
