garydgregory commented on code in PR #441:
URL: https://github.com/apache/commons-compress/pull/441#discussion_r1403439399
##########
src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java:
##########
@@ -362,7 +362,11 @@ public int read(final byte[] b, final int off, final int
len) throws IOException
private long readAsciiLong(final int length, final int radix) throws
IOException {
final byte[] tmpBuffer = readRange(length);
- return Long.parseLong(ArchiveUtils.toAsciiString(tmpBuffer), radix);
+ try {
Review Comment:
Hello @yakovsh
It can be moved, sure. I would not use ExactMath since that's supposed to be
a wrapper for Math exact APIs. If the refactored new API can be
package-private, then please do that, if not, we'll have to live with a larger
public API footprint. TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
