yakovsh commented on code in PR #441:
URL: https://github.com/apache/commons-compress/pull/441#discussion_r1406805346


##########
src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java:
##########
@@ -362,7 +362,11 @@ public int read(final byte[] b, final int off, final int 
len) throws IOException
 
     private long readAsciiLong(final int length, final int radix) throws 
IOException {
         final byte[] tmpBuffer = readRange(length);
-        return Long.parseLong(ArchiveUtils.toAsciiString(tmpBuffer), radix);
+        try {

Review Comment:
   I created a new utils class ("ParsingUtils") and moved both Long and Integer 
parsing from strings to that class + a unit test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to