garydgregory commented on code in PR #441:
URL: https://github.com/apache/commons-compress/pull/441#discussion_r1407704020
##########
src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java:
##########
@@ -1634,19 +1627,19 @@ private void processPaxHeader(final String key, final
String val, final Map<Stri
setLinkName(val);
break;
case "gid":
- setGroupId(Long.parseLong(val));
+ setGroupId(ParsingUtils.parseLongValue(val, 10));
Review Comment:
The PR now add this "10" magic number in many places. Is it ever NOT 10? Or,
do we need a specialized version of `parseLongValue` as `parseLongValueBase10`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
