theshoeshiner commented on PR #1156: URL: https://github.com/apache/commons-lang/pull/1156#issuecomment-1887574804
In JUnit's defense, you could argue that assertThrows does not, and should not, throw the underlying exception because it is not "exceptional" - In that the presence of the exception is not something that the caller should be forced to handle in an exceptional manner, in fact just the opposite. But yea still doesn't change the fact that it is indeed returning an Exception object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
