elharo commented on PR #1156: URL: https://github.com/apache/commons-lang/pull/1156#issuecomment-1887688240
Reserving the right to change my mind later, but I think that if you want to deliver the message to all listeners, even when the an earlier listener throws an exception, I'd want a custom exception that bundles up all the listener exceptions. If this is synchronous, I think the dispatcher should probably be ready to handle any error condition that can arise from calling a listener. So maybe it shouldn't be a generic utility at all. The dispatcher should not be in commons lang. Rather it should be in the client project that knows what the listeners are doing, knows what errors can happen and why, and knows how to handle them. If it's asynchronous, then that's what ExecutorService/Executor/Executors is for, and we shouldn't reinvent that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
