StefanOltmann commented on code in PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#discussion_r1501381252
##########
src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputField.java:
##########
@@ -66,6 +66,10 @@ public boolean bytesEqual(final byte[] data) {
return Arrays.equals(bytes, data);
}
+ public boolean bytesEqual(final TiffOutputField other) {
+ return Arrays.equals(bytes, other.bytes);
+ }
Review Comment:
The original test did not compare the bytes. This is needed to really detect
data truncation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
