garydgregory commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-1962411393
Hello @StefanOltmann I don't think I understand what you are saying here. What I see in this PR is: - the addition of a utility method to main and - changes to a test case - the claim that this PR proves that another PR (#359) fixes an issue But, this means (to me) that the test should fail without the fix in #359, it does not, since that PR is open. So the test does not test what it claims to test. In general, you should include a test with a PR, which #359 does not. So I would ask that you provide one PR with the main and test changes in the same PR, not split into two. TY! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
