StefanOltmann commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-1962435297
> But, this means (to me) that the test should fail without the fix in #359, it does not, since that PR is open. So the test does not test what it claims to test. Please read carefully what I wrote here: > Drop this [testfile.jpg](https://github.com/apache/commons-imaging/assets/9299303/2826b4ee-473a-45fb-b9fc-2168b9ae3fca) into src/test/resources/data/images/jpg to make the test fail. You won't accept a PR with a failing test, would you? So I did not include the test file. And if I fix the test and the code in one PR, you will say "nothing changed". The test now does not change, because none of the test files present raises the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
