kinow commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-1987367351
>If you test it locally don't forget to drop in the test file as described in my first post. Noted :+1: You did a great job on the comments (in the code and in the pull request). We do not always get pull requests like this :slightly_smiling_face: Apologies for the delay, but wait just a bit more and this should be fixed. For future PR's; it's common to have partial reviews. In some cases a reviewer might leave a note-to-self or to other committers (and maybe bring it to discuss over Slack or mailing list) in one of the comments, or may leave a partial review about something that, once the rest of the code is reviewed, does not need to be changed. But once the review is done, you can be sure that someone will tag you, like "@StefanOltmann, I've reviewed it and it looks great! LGTM!", or "@StefanOltmann, can you look at my comment about the change you did in the code XPTO.java, please? I did not understand why you modified this or that". Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
