StefanOltmann commented on code in PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#discussion_r1518866794
##########
src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputField.java:
##########
@@ -66,6 +66,10 @@ public boolean bytesEqual(final byte[] data) {
return Arrays.equals(bytes, data);
}
+ public boolean bytesEqual(final TiffOutputField other) {
+ return Arrays.equals(bytes, other.bytes);
+ }
Review Comment:
@kinow, appreciate your review!
I understand the importance of being cautious when introducing a new API.
Given the existence of a closely related method above (primarily utilized by
tests), I believed its inclusion would be acceptable.
I've implemented the requested change, and it's now package private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
