kinow commented on code in PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#discussion_r1518826722
##########
src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputField.java:
##########
@@ -66,6 +66,10 @@ public boolean bytesEqual(final byte[] data) {
return Arrays.equals(bytes, data);
}
+ public boolean bytesEqual(final TiffOutputField other) {
+ return Arrays.equals(bytes, other.bytes);
+ }
Review Comment:
Reading the code on my mobile, but this was the only part that called my
attention, everything else looks good (can look with the IDE later today/this
week).
IMO we should see if we can move these methods to test class (or internal
package), and these should not be exposed/shipped as public API for Imaging.
But the update looks fine. Just need some moments with ide and coverage tool
to confirm.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
