garydgregory commented on PR #602:
URL: https://github.com/apache/commons-compress/pull/602#issuecomment-2456746858

   Hello @vincexjl 
   
   Thank you for your PR.
   
   You'll have to provide unit tests to show that these changes work. The tests 
should fail when the change to 'main' are not applied.
   
   All new public and protected code should have Javafoc with 'since tags.
   
   Make sure you run "mvn" by itself before you push.
   
   Do you have a link to the Gzip specification that define that non-ASCII 
bytes are allowed?
   
   Ty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to