garydgregory commented on PR #602: URL: https://github.com/apache/commons-compress/pull/602#issuecomment-2460589395
Hi @ppkarwasz and @vincexjl > Encode the filename as ISO-8859-1. The name was already to ISO-8859-1 with an ASCII percent-encoded backstop. The behavior is still the same. Now there is a Charset override. I think I'm hearing you say, is that instead of falling back to ASCII percent-encoded, just don't write the name at all. Is that so? I don't think that's the whole picture though but I could be wrong ;-) I think the desire is to support simplified Chinese characters, and that can't be done with ISO-8859-1 (please correct me if I'm wrong). I made a note in the Javadoc for `setFileNameCharset` that using a non-ISO-8859-1 Charest may cause interoperability issues. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
