vincexjl commented on PR #602: URL: https://github.com/apache/commons-compress/pull/602#issuecomment-2459933219
@ppkarwasz @garydgregory hello thank you for your reply, as I was saying, when we use GzipCompressorOutputStream(final OutputStream out) . it mean when we don`t use GzipParameters, the filename encode is decided by Operating system. but when we use GzipParameters,the filename will encode by iso-8859-1 or new url encode. I think this is unreasonable. this will cause us to unzip the gzfile, filename is different with dont use GzipParameters. To maintain consistency, i think need add gzipParameter.setFilenameCharset to resolve it. I also kept it when we dont set this, still the same before when gzipParameters.getFilenameCharset is null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
