garydgregory commented on PR #502: URL: https://github.com/apache/commons-csv/pull/502#issuecomment-2489305349
Hello @DarrenJAN I don't understand how a String can work. Let's say I specify I want to read a CSV file encoded in Charset X. The Charset (encoder) that is used by the new counting feature MUST match X, otherwise the counting risks being mismatched. Or am I missing something? Hence, the need for a boolean or some other type that's not a Charset, maybe even an Enum if there a need for something more than on and off. If the PR only supports a subset of Charsets, then the Javadoc of the setter for the feature toggle must document this. It's also likely that I am not seeing how the PR code only supports some Charsets and not others. What's missing? TY. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
