DarrenJAN commented on PR #502: URL: https://github.com/apache/commons-csv/pull/502#issuecomment-2563183872
Hi @garydgregory, Happy Holidays! The changes that I made: 1. New private elements do not need a Javadoc since tag. 2. Return type of **getCharByte** is int 3. Change **getCharBytes** to **getEncodedCharLength** 4. Add Javadoc @param for enableByteTracking 5. CSVRecord: Remove the old constructors and adapt the existing test. 6. Change **characterByte** to **bytePosition** @yunzvanessa How do you think this change? Test: mvn <img width="1117" alt="image" src="https://github.com/user-attachments/assets/9ac9328f-fd2d-4585-8113-93ec3b03e079"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
