DarrenJAN commented on PR #502: URL: https://github.com/apache/commons-csv/pull/502#issuecomment-2489509913
Hi Gary, In ExtendedBufferedReader.java, this function getCharBytes(int current), the logic of this code is based on the UTF-8 encoding specification. We need extra implementation to support the full set of characters. "Hence, the need for a boolean or some other type that's not a Charset, maybe even an Enum if there a need for something more than on and off." --- We used a String here. We only did a simple check whether String is null to enable this encoder feature since our customers only asked for UTF-8 encoder. I agree with adding a flag to control this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
