garydgregory commented on PR #629: URL: https://github.com/apache/commons-compress/pull/629#issuecomment-2566506538
Hello @ddeschenes-1 Thank you for your PR. In general, I like the idea of documenting the existing behavior, so I am OK with the current PR, BUT: The "lingering" GzipParameters data in an input stream sounds like a bug. I would rather have this metadata be sound and predictable before we invent a new setting to detect when a new `GzipParameters` is created/initialized. WRT to adding new settings, I want to stop inflating the constructor space, so I am using builders from now on, for example, see `org.apache.commons.compress.archivers.sevenz.SevenZFile.Builder`. I added support for `equals()` and `hashCode()` to `GzipParameters` to facilitate any checks. How could the input stream be changed to avoid the "lingering" issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
