ddeschenes-1 commented on PR #629: URL: https://github.com/apache/commons-compress/pull/629#issuecomment-2566640102
Good catch on the compression level. One more field on the pile... At this point I think we need to create a new GP and (atomically) assign it when ready. If a user is interested in the first GP, he does so after the constructor. Any other time, he calls getMetadata() and gets whatever last seen GP is there. For now, that's good enough to stabilize the behavior in a non surprising way. +1 on adding a protected method called **onGzipMember()** (no-arg) The call would be made **after** setting the GP of course so the subclass at can read it. This covers the initial member on construction too. I'm not too keen on coding it and wasting time on build failures and spaces... So go ahead! We can drop this PR, you'd likely write the proper javadoc anyway. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
