ddeschenes-1 commented on PR #629: URL: https://github.com/apache/commons-compress/pull/629#issuecomment-2566565560
It started like a bug in my mind, but it evolved... (it's nto a bug; it's a feature? lol) We'd have to choose between keeping the 1st GP and ignoring the subsequent ones, or keeping the last GP and clobbering the previous one. That's where I got torn. If a filename or comment is set, it is likely meaningful in the 1st member. If extras are added, it could be valuable anywhere. "mtime" is meant to indicate modification time, so taking it from the last member is likely to be more meaningful. But again, it's the mtime of the member really, not the whole file. See, there is no good answer so I'd pass the puck to the user with a listener. As for what the GCIS should do regardless of a listener, I think the lingering fields are not so bad because it provides a **default integrator** of the whole stream. Maybe that's the phrasing we should use to put a positive spin on this behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
