Alwaysgaurav1 commented on PR #1801: URL: https://github.com/apache/commons-lang/pull/1801#issuecomment-6059283786
Hi @garydgregory, I have reworked this PR based on your feedback and the original consensus on [LANG-796](https://issues.apache.org/jira/browse/LANG-796): - Removed all 9 newly introduced `TimeZone` overloads to keep `DateUtils` lean. - Clarified the Javadocs on `add` and all `add*` methods (`addDays`, `addHours`, `addWeeks`, etc.) explaining that they perform calendar arithmetic using `Calendar` with the default time zone and locale, and are subject to Daylight Saving Time offsets. - Added `testAddDaysDaylightSavingTime()` in `DateUtilsTest` asserting the documented 23h spring and 25h autumn calendar arithmetic behavior. All Checkstyle checks and time package tests pass cleanly. Ready for another look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
