oscerd commented on PR #450: URL: https://github.com/apache/commons-cli/pull/450#issuecomment-6470259241
Sorry @garydgregory, that wasn't intentional. The `isValuesEmpty()` check I removed was also protecting options that already have a value, like the one in your new test, so the property value went into a full list and `Option.add()` threw. I put the check back, on the copy this time, so an existing value still wins and `Options` is still not modified. Rebased on master, your test passes along with the new ones. I also added a short note to the `parse(Options, Properties, NonOptionAction, String...)` Javadoc about how property values are used. Thanks for catching it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
