garydgregory commented on PR #449: URL: https://github.com/apache/commons-cli/pull/449#issuecomment-6496360487
Hello @oscerd As you note this is a behavior breaking change. I want to confirm with you that this is really the intent. As always when the docs and code don't match we have to ask "What's the intent and ground truth for this feature?" and also how much does compatibility matter. What's confusing is that the PR doesn't update the documentation. The class still says `!` makes the preceding option mandatory, while the updated implementation makes the following option required. Please review that code and docs match after changing code! ;) The code now explicitly throws `IllegalArgumentException` but doesn't document it. We don't always document unchecked exceptions that we passthrough, but for the ones we throw, in this case, I think we should. Setting to draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
