oscerd opened a new pull request, #449:
URL: https://github.com/apache/commons-cli/pull/449
The `PatternOptionBuilder` Javadoc says `!` goes in front of an option to
make it mandatory, and its example, `parsePattern("vp:!f/")`, is meant to make
`-f` required. In practice the flag was only applied when the next option
character was read, so it landed on the option *before* the `!`: the example
makes `-p` required and leaves `-f` optional. It only worked as documented when
`!` was the very first character of the pattern, which is the one case
`testRequiredOption` covers, so the tests never caught it.
With this change `!` marks the option that follows it. Two things behave
differently, and both are in `changes.xml`:
- A pattern like `"p:!f/"` now makes `f` required instead of `p`.
- A `!` with no option after it (`"a:b!"`, `"a!:"`) now throws
`IllegalArgumentException` instead of being quietly applied to the previous
option. Failing at startup seemed better than having a required option silently
turn optional.
The new tests cover the Javadoc example end to end, `!` in the middle of a
pattern, several `!` in one pattern, and the dangling cases. They fail on
master and pass with the change.
- [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) if you use
Artificial Intelligence (AI).
- [x] I used AI to create any part of, or all of, this pull request. Which
AI tool was used to create this pull request, and to what extent did it
contribute? Claude Code (Claude Opus 5.5) was used to analyze the issue and to
prepare the change, its tests and this description.
- [x] Run a successful build using the default
[Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command
line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied. This may not always be possible,
but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body. Note that a maintainer may squash commits during the merge process.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
