oscerd commented on PR #449: URL: https://github.com/apache/commons-cli/pull/449#issuecomment-6497699333
Sorry Gary, I had it backwards. I went back to the history: in CLI-55 the example is `hc!<` making `c` mandatory, so `!` was always meant to mark the option before it. That's what the code does and what your Javadoc now says. The 2008 sentence "The exclamation mark precede a mandatory option" is what threw me off. Compatibility matters more here, so I've backed out the behavior change. Nothing changes for existing patterns and there's no new exception anymore. The PR now only adds tests for the current behavior (the Javadoc example, the CLI-55 example, a trailing `!` and several `!` in one pattern) and one sentence saying that a `!` at the start of the pattern marks the first option. I've updated the title and description to match, and thanks for sorting out the conflicts. P.S. 7dfda5bb turned the `TODO` at the end of the class Javadoc into `ODO`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
