[
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072285#comment-13072285
]
Matthew Pocock commented on CODEC-125:
--------------------------------------
=The code coverage shows some code untouched, so there needs to be some code
review.
Yes. Since the rewrite I haven't looked back at the test coverage. It is
possible that some stuff is now never called, and that other stuff is not
exercised by the range of circumstances considered by existing tests.
=We also need more tests with validated encoded names.
I agree. However, it is quite a big job tracking down names that exercise
each/every encoding rule.
=RuleTest is a no-op now. Should that go away completely or be reimplemented?
With the rewrite, the existing test became obsolete. I expect that when we add
tests to ratchet up the code coverage that we will end up with some
rule-specific tests.
> Implement a Beider-Morse phonetic matching codec
> ------------------------------------------------
>
> Key: CODEC-125
> URL: https://issues.apache.org/jira/browse/CODEC-125
> Project: Commons Codec
> Issue Type: New Feature
> Reporter: Matthew Pocock
> Priority: Minor
> Attachments: bm-gg.diff, bmpm.patch, bmpm.patch, bmpm.patch,
> bmpm.patch, bmpm.patch, bmpm.patch, bmpm.patch, bmpm.patch, majorFix.patch,
> testEncodeGna.patch
>
>
> I have implemented Beider Morse Phonetic Matching as a codec against the
> commons-codec svn trunk. I would like to contribute this to commons-codec.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
