[ 
https://issues.apache.org/jira/browse/CODEC-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072496#comment-13072496
 ] 

Tamas Kende commented on CODEC-125:
-----------------------------------

Matthew:
I started to compare the results of the php implementation and this one, and I 
found something with strings: "átz" and "ácz" in ending position. Here the 
encode method returns with empty string:
{code:title=Test.java|borderStyle=solid}
 @Test
    public void testEncodeAtz() throws EncoderException {
        BeiderMorseEncoder bmpm = new BeiderMorseEncoder();
        bmpm.setNameType(NameType.GENERIC);
        bmpm.setRuleType(RuleType.APPROX);
        Assert.assertFalse(bmpm.encode("ácz").equals(""));
        Assert.assertFalse(bmpm.encode("átz").equals(""));
    }
{code}
It is broken with an accented char (áéűőä) and the 'cz' 'tz' string. But only 
in ending position.

> Implement a Beider-Morse phonetic matching codec
> ------------------------------------------------
>
>                 Key: CODEC-125
>                 URL: https://issues.apache.org/jira/browse/CODEC-125
>             Project: Commons Codec
>          Issue Type: New Feature
>            Reporter: Matthew Pocock
>            Priority: Minor
>         Attachments: bm-gg.diff, bmpm.patch, bmpm.patch, bmpm.patch, 
> bmpm.patch, bmpm.patch, bmpm.patch, bmpm.patch, bmpm.patch, majorFix.patch, 
> testEncodeGna.patch
>
>
> I have implemented Beider Morse Phonetic Matching as a codec against the 
> commons-codec svn trunk. I would like to contribute this to commons-codec.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to