[ 
https://issues.apache.org/jira/browse/OGNL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114428#comment-13114428
 ] 

Daniel Pitts commented on OGNL-8:
---------------------------------

Looking even more closely at the JJTree documentation, it looks like the 
expectation is that node classes are editable after they are generated :-(.  
This is never explicitly determined in the docs, but 

The Parser on the other hand is what needs to be regeneratable, and it looks 
like it is easy to do.  I'll attach a patch.

What this *doesn't* buy us is the ability to adjust node generating features 
(for instance, visitor pattern support).

This would have to be added by hand. Which is just as well, as good visitor 
support would need generics, and jjtree doesn't yet support that. 

The current code-base doesn't need visitor pattern support, but I'm thinking of 
a few refactorings that could benefit from it, so I'm going to open a new 
feature request here and provide a patch.

> use javacc to generate AST* and OGNLParser Java sources
> -------------------------------------------------------
>
>                 Key: OGNL-8
>                 URL: https://issues.apache.org/jira/browse/OGNL-8
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>         Attachments: OGNL-8.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to