[ 
https://issues.apache.org/jira/browse/OGNL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120702#comment-13120702
 ] 

Simone Tripodi commented on OGNL-8:
-----------------------------------

Sorry to be late Christian, but didn't have enough spare time :(

I experienced some issue on applying the patch on my local copy, even 
checking-it out form scratch, got the following error:

{code}
Hunk #1 FAILED at 1.
File src/main/java/org/apache/commons/ognl/JavaCharStream.java is not empty 
after patch, as expected
1 out of 1 hunk FAILED -- saving rejects to file 
src/main/java/org/apache/commons/ognl/JavaCharStream.java.rej
patching file src/main/java/org/apache/commons/ognl/OgnlParser.java
{code}

I ask the kind favor someone else applies and test it; otherwise Christian 
commits it then we will review - it is versioned, we can apply improvements 
later or revert in any way!
                
> use javacc to generate AST* and OGNLParser Java sources
> -------------------------------------------------------
>
>                 Key: OGNL-8
>                 URL: https://issues.apache.org/jira/browse/OGNL-8
>             Project: OGNL
>          Issue Type: Task
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>         Attachments: OGNL-8-keep-custom-AST.patch, OGNL-8.patch, 
> patch-ognl-8-v1.patch, patch-ognl-8-v2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to