[
https://issues.apache.org/jira/browse/OGNL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119669#comment-13119669
]
Christian Grobmeier commented on OGNL-8:
----------------------------------------
Daniel and others,
I have attached my own patch I did before I saw you have added one. It should
be similar to what you did, because I:
- moved jj/jjt files to src/main/javacc
- integrated a javacc maven plugin into the pom.xml [1]
- renamed the packages of the generated classes into o.a.c.ognl.javacc
- removed the old sources
- modified many AST* classes to suck the *.ognl.javacc classes
- made mvn generate-sources
- and runned all Junit tests from Eclipse.
This worked well for me. According to your explaination it seems to be quite ok
to modify the AST* files. My patch does reflect this too. The main difference
is I am not going the nice way as you do but a bit more dirty way and generate
into the src/main/java package. This resolves the ide problem and the
maven-can-only-have-one-src-foler problem.
If you want could take a look at it? Maybe we can make up a good solution with
combined forces.
> use javacc to generate AST* and OGNLParser Java sources
> -------------------------------------------------------
>
> Key: OGNL-8
> URL: https://issues.apache.org/jira/browse/OGNL-8
> Project: OGNL
> Issue Type: Task
> Reporter: Olivier Lamy
> Assignee: Olivier Lamy
> Attachments: OGNL-8-keep-custom-AST.patch, OGNL-8.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
