[ 
https://issues.apache.org/jira/browse/CSV-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227754#comment-13227754
 ] 

Emmanuel Bourg commented on CSV-57:
-----------------------------------

The use case it to first read the headers, and then the content of the file.

I agree on the null return value, an empty array is better to avoid a null 
check.
                
> CSVParser.getRecords() contract is confusing
> --------------------------------------------
>
>                 Key: CSV-57
>                 URL: https://issues.apache.org/jira/browse/CSV-57
>             Project: Commons CSV
>          Issue Type: Improvement
>          Components: Parser
>            Reporter: Benedikt Ritter
>            Priority: Minor
>
> {{CSVParser.getRecords()}} has a confusing contract. It will return all 
> records from the current position instead of all values in the parsed file. 
> This implies that users will first iterate over the records using the 
> iterator and then call getRecords(). This seems like an unlikely use case.
> Also, it is not good practice to return {{null}}. So getRecords() should 
> return an empty array, if no records can be found.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to