[ https://issues.apache.org/jira/browse/CSV-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229562#comment-13229562 ]
Sebb commented on CSV-57: ------------------------- I use displayed tab width 4, use spaces for tabs. I've not found out how to stop Eclipse adding leading spaces to blank lines, so I tend to delete those as I go along. > CSVParser.getRecords() contract is confusing > -------------------------------------------- > > Key: CSV-57 > URL: https://issues.apache.org/jira/browse/CSV-57 > Project: Commons CSV > Issue Type: Improvement > Components: Parser > Reporter: Benedikt Ritter > Priority: Minor > Attachments: CSV-57.txt > > > {{CSVParser.getRecords()}} has a confusing contract. It will return all > records from the current position instead of all values in the parsed file. > This implies that users will first iterate over the records using the > iterator and then call getRecords(). This seems like an unlikely use case. > Also, it is not good practice to return {{null}}. So getRecords() should > return an empty array, if no records can be found. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira