[
https://issues.apache.org/jira/browse/CSV-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229547#comment-13229547
]
Benedikt Ritter commented on CSV-57:
------------------------------------
Sorry, the patch does contain one tab character. Can you please be so kind and
replace that with spaces (if you decide to apply it)? I'm really having
problems to create patches, because I don't know where to get the right
formatter settings for eclipse. Which settings are you using, sebb?
> CSVParser.getRecords() contract is confusing
> --------------------------------------------
>
> Key: CSV-57
> URL: https://issues.apache.org/jira/browse/CSV-57
> Project: Commons CSV
> Issue Type: Improvement
> Components: Parser
> Reporter: Benedikt Ritter
> Priority: Minor
> Attachments: CSV-57.txt
>
>
> {{CSVParser.getRecords()}} has a confusing contract. It will return all
> records from the current position instead of all values in the parsed file.
> This implies that users will first iterate over the records using the
> iterator and then call getRecords(). This seems like an unlikely use case.
> Also, it is not good practice to return {{null}}. So getRecords() should
> return an empty array, if no records can be found.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
