[
https://issues.apache.org/jira/browse/MATH-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284644#comment-13284644
]
Dennis Hendriks commented on MATH-764:
--------------------------------------
bq. A aimple way to provide the requested functionality without breaking
compatibility might be to add setRandomGenerator methods to
AbstractXxxDistribution. This violates immutability, but the
reseedRandomGenerator methods currently provided arguably do this already with
essentially the same practical consequences.
Would it not be better to allow passing in a RandomData instance via the
constructors? That way, instead of constructing a default RandomDataImpl with
default random generator, the user can provide their own RandomData, which they
constructed using their own random generator. This way, the distributions are
still immutable.
> New sample() API should accept RandomGenerator as parameter
> -----------------------------------------------------------
>
> Key: MATH-764
> URL: https://issues.apache.org/jira/browse/MATH-764
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Alex Bertram
> Attachments: sampler-refactor.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This may come to late as I know the 3.0 release is nearing completion, but I
> had some concerns about the new sample() method on the math3 RealDistribution
> interface.
> Specifically, there doesn't seem to be a way to supply a random generator to
> the sampler. Perhaps it would be better to have a factory method on the
> RealDistribution interface that accepted a RandomGenerator and returns an
> instance of some new interface, Sampler, which contains the sample() methods.
> That is:
> interface RealDistribution {
> Sampler createSampler(RandomGenerator generator);
> Sample createSampler(); // uses default RandomGenerator
> }
> interface Sampler {
> double sample();
> double[] sample(int sampleSize);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
