[
https://issues.apache.org/jira/browse/MATH-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285869#comment-13285869
]
Gilles commented on MATH-764:
-----------------------------
bq. Once again, the distributions already have random generators.
We know that. But see my very first comment:
bq. The addition of the "sample" methods in the distribution classes were
accepted, as syntactic sugar, on the premisses that _users should be satisfied
with the default RNG._
The dichotomy was to avoid to entirely duplicate the RNG functionality (both in
"RandomData" and in the various distribution classes).
But if Phil is now OK with relocating the various method of "RandomData" to
their corresponding distribution, that would solve the problem in another way:
Deprecate (then remove) RandomData and make the RNG an argument to constructors
of the distribution classes, as you propose.
We could also keep RandomData, for backwards compatibility, but have the
methods redirect the actual computation to the distribution classes.
> New sample() API should accept RandomGenerator as parameter
> -----------------------------------------------------------
>
> Key: MATH-764
> URL: https://issues.apache.org/jira/browse/MATH-764
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.0
> Reporter: Alex Bertram
> Attachments: sampler-refactor.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This may come to late as I know the 3.0 release is nearing completion, but I
> had some concerns about the new sample() method on the math3 RealDistribution
> interface.
> Specifically, there doesn't seem to be a way to supply a random generator to
> the sampler. Perhaps it would be better to have a factory method on the
> RealDistribution interface that accepted a RandomGenerator and returns an
> instance of some new interface, Sampler, which contains the sample() methods.
> That is:
> interface RealDistribution {
> Sampler createSampler(RandomGenerator generator);
> Sample createSampler(); // uses default RandomGenerator
> }
> interface Sampler {
> double sample();
> double[] sample(int sampleSize);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
