[ 
https://issues.apache.org/jira/browse/MATH-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285665#comment-13285665
 ] 

Phil Steitz commented on MATH-764:
----------------------------------

I am starting to think that my historical resistance to moving the sampling 
functionality entirely to within the distributions was wrong.  I would 
personally be OK with refactoring to do this move, ensuring that distributions 
(or at least the sampling methods) had configurable RandomGenerators.
                
> New sample() API should accept RandomGenerator as parameter
> -----------------------------------------------------------
>
>                 Key: MATH-764
>                 URL: https://issues.apache.org/jira/browse/MATH-764
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Alex Bertram
>         Attachments: sampler-refactor.diff
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> This may come to late as I know the 3.0 release is nearing completion, but I 
> had some concerns about the new sample() method on the math3 RealDistribution 
> interface. 
> Specifically, there doesn't seem to be a way to supply a random generator to 
> the sampler. Perhaps it would be better to have a factory method on the 
> RealDistribution interface that accepted a RandomGenerator and returns an 
> instance of some new interface, Sampler, which contains the sample() methods. 
> That is:
> interface RealDistribution {
>     Sampler createSampler(RandomGenerator generator);
>     Sample createSampler(); // uses default RandomGenerator
> }
> interface Sampler {
>     double sample();
>     double[] sample(int sampleSize);
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to