[
https://issues.apache.org/jira/browse/MATH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440243#comment-13440243
]
Gilles commented on MATH-851:
-----------------------------
I fully agree with Sébastien: Your proposed code not being committed right away
is not (primarily) related to the discussion about formatting rules.
It's rather that accepting a new feature is not automatic; just the fact that
it might a useful code snippet is not enough to include it in a library with
some purported design goals (which can be fuzzily defined too, I admit) ;).
One way to speed the process is to demonstrate the usefulness of the new
feature in a "real" application. It could be in a non-trivial unit test, or in
a new section of the "user guide".
Contributions that already fit within the existing design of Commons Math are
also likely to be more rapidly committed. Examples are:
* a bug-fix,
* an efficiency improvement, or
* an implementation of an existing feature (e.g. a new "interpolation" scheme).
Any of those would also help you getting "incrementally" acquainted with the
formatting conventions.
> Add convolution
> ---------------
>
> Key: MATH-851
> URL: https://issues.apache.org/jira/browse/MATH-851
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Clemens Novak
> Priority: Minor
> Attachments: Filter.java, FilterTest.java, FilterUtils.java,
> FilterUtils.java, FilterUtilsTest.java, FilterUtilsTest.java
>
>
> I created a function performing (one-dimensional) convolution. Currently, the
> function is in a class called Filter, but I am not sure whether this is the
> appropriate place for it(?).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
