[
https://issues.apache.org/jira/browse/COMPRESS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085811#comment-15085811
]
Torsten Curdt commented on COMPRESS-328:
----------------------------------------
That's easier from a compatibility side of things. Given there is the parameter
to the constructor and the for the sake of keeping the API clean I am not sure
it's the better choice - but that certainly is an option, too.
> TarArchiveEntry preserveLeadingSlashes has no effect on setName
> ---------------------------------------------------------------
>
> Key: COMPRESS-328
> URL: https://issues.apache.org/jira/browse/COMPRESS-328
> Project: Commons Compress
> Issue Type: Improvement
> Reporter: Torsten Curdt
> Priority: Minor
>
> We've run into an inconsistency with the TarArchiveEntry at jdeb.
> https://github.com/tcurdt/jdeb/issues/217
> You can create a `TarArchiveEntry(String name, boolean
> preserveLeadingSlashes)` but the `preserveLeadingSlashes` is only applied in
> the constructor.
> https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java#L392
> I am proposing to turn `preserveLeadingSlashes` into a read-only property and
> use the value on `setName()`, too (instead of just false).
> This has some implications and maybe some backwards compatibility issues -
> but even then I think it would be the right thing to do.
> I am happy to make the change but thought to discuss this first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
