[
https://issues.apache.org/jira/browse/COMPRESS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101773#comment-15101773
]
Stefan Bodewig commented on COMPRESS-328:
-----------------------------------------
Oh, I've likely got myself confused by changing opinions back and forth :-)
Your option 2 is fine with me. And as I still don't really understand why
anybody would use the constructor with name and invoke setName I'm not afraid
of breaking backwards compatibility.
Re: {{normalize}} most others replace \ with / not matter what the current
platform is and don't contain any special code for leading slashes. This is a
feature that has only ever been asked for in the context of tar - not sure why.
> TarArchiveEntry preserveLeadingSlashes has no effect on setName
> ---------------------------------------------------------------
>
> Key: COMPRESS-328
> URL: https://issues.apache.org/jira/browse/COMPRESS-328
> Project: Commons Compress
> Issue Type: Improvement
> Reporter: Torsten Curdt
> Priority: Minor
>
> We've run into an inconsistency with the TarArchiveEntry at jdeb.
> https://github.com/tcurdt/jdeb/issues/217
> You can create a `TarArchiveEntry(String name, boolean
> preserveLeadingSlashes)` but the `preserveLeadingSlashes` is only applied in
> the constructor.
> https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java#L392
> I am proposing to turn `preserveLeadingSlashes` into a read-only property and
> use the value on `setName()`, too (instead of just false).
> This has some implications and maybe some backwards compatibility issues -
> but even then I think it would be the right thing to do.
> I am happy to make the change but thought to discuss this first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
