[ 
https://issues.apache.org/jira/browse/COMPRESS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101205#comment-15101205
 ] 

Stefan Bodewig commented on COMPRESS-328:
-----------------------------------------

Sorry for the delay.

I can live with using {{preserveLeadingSlashes}} in {{setName}} as well - maybe 
add a new constructor that sets the flag but doesn't require the name at the 
same time.

I don't think any of the other archivers uses a normalization similar to tar.

> TarArchiveEntry preserveLeadingSlashes has no effect on setName
> ---------------------------------------------------------------
>
>                 Key: COMPRESS-328
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-328
>             Project: Commons Compress
>          Issue Type: Improvement
>            Reporter: Torsten Curdt
>            Priority: Minor
>
> We've run into an inconsistency with the TarArchiveEntry at jdeb.
>   https://github.com/tcurdt/jdeb/issues/217
> You can create a `TarArchiveEntry(String name, boolean 
> preserveLeadingSlashes)` but the `preserveLeadingSlashes` is only applied in 
> the constructor.
> https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java#L392
> I am proposing to turn `preserveLeadingSlashes` into a read-only property and 
> use the value on `setName()`, too (instead of just false).
> This has some implications and maybe some backwards compatibility issues - 
> but even then I think it would be the right thing to do.
> I am happy to make the change but thought to discuss this first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to