[
https://issues.apache.org/jira/browse/MATH-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233484#comment-15233484
]
Gilles commented on MATH-1290:
------------------------------
bq. if the branch didn't quite line up with math-1290, this may be because you
told me to check out the devevelop branch for the pull request so this is what
I did.
When I told you that, branch "feature-MATH-1290" did not yet exist.
I created it at some point (see [this
comment|https://issues.apache.org/jira/browse/MATH-1290?focusedCommentId=15213268&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15213268]
where I wrote that the branch was available).
Then when work continues on this issue (like with the little changes I did), it
has to be done on the new branch (see [this
comment|https://issues.apache.org/jira/browse/MATH-1290?focusedCommentId=15218117&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15218117]
where I wrote that you'd have to check out "feature-MATH1290"): that's the
only way one can review all the code pertaining to a given issue.
bq. this time I'll check out the math-1290 branch and merge with that, and that
will become the master branch of my fork.
When you check out "feature-MATH-1290", you can make some change in it (as
wrote in [this
comment|https://issues.apache.org/jira/browse/MATH-1290?focusedCommentId=15233059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15233059]).
Then you don't have to "merge" with your "master", you just commit the changes
in that same branch and issue the pull request for the modifications wrt
upstream's "feature-MATH-1290".
Especially, if you have made changes, in your "master" branch, that pertain to
another issue, you certainly _should_ not make a pull request based on that
branch!
Sorry if the workflow was not quite clear before.
> Additions to Complex Utils; creation of conversion methods between Complex[],
> double[], float[], and interleaved arrays
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: MATH-1290
> URL: https://issues.apache.org/jira/browse/MATH-1290
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.5
> Reporter: Eric Barnhill
> Priority: Minor
> Labels: newbie, patch
> Fix For: 4.0
>
> Attachments: ComplexUtils.java, ComplexUtils.java, ComplexUtils.java,
> ComplexUtils.java, ComplexUtilsTest.java, ComplexUtilsTest.java,
> ComplexUtilsTest.java, ComplexUtilsTest.java, LaguerreSolver.java
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I propose to add several new methods to the ComplexUtils class enabling easy
> conversion between Complex[] arrays, real or imaginary double[] or float[]
> arrays, and interleaved complex double[] or float[] arrays. The last two in
> particular are beneficial to have for OpenCL implementations and the
> JTransforms library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
