[ 
https://issues.apache.org/jira/browse/MATH-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239588#comment-15239588
 ] 

Gilles commented on MATH-1290:
------------------------------

Second experiment, using a pull-request that was just posted to the "dev" ML.
Note: Prior to that short command-line session, I did not have _anything_ 
related to "Commons Lang" on my machine.

{noformat}
gilles@eccen:~/tmp/git_pr_test$ git clone 
http://git-wip-us.apache.org/repos/asf/commons-lang.git
Cloning into 'commons-lang'...
remote: Counting objects: 55686, done.
remote: Compressing objects: 100% (8837/8837), done.
remote: Total 55686 (delta 27802), reused 52720 (delta 26438)
Receiving objects: 100% (55686/55686), 6.30 MiB | 1.95 MiB/s, done.
Resolving deltas: 100% (27802/27802), done.
Checking connectivity... done.
gilles@eccen:~/tmp/git_pr_test$ ls
commons-lang
gilles@eccen:~/tmp/git_pr_test$ cd commons-lang/
gilles@eccen:~/tmp/git_pr_test/commons-lang$ git status -uno
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit (use -u to show untracked files)
gilles@eccen:~/tmp/git_pr_test/commons-lang$ git pull 
https://github.com/marcjansen/commons-lang patch-1
remote: Counting objects: 11, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 11 (delta 0), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (11/11), done.
>From https://github.com/marcjansen/commons-lang
 * branch            patch-1    -> FETCH_HEAD
Updating 158373b..27bf6f0
Fast-forward
 src/main/java/org/apache/commons/lang3/time/DateUtils.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
gilles@eccen:~/tmp/git_pr_test/commons-lang$ git status -uno
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
  (use "git push" to publish your local commits)
nothing to commit (use -u to show untracked files)
gilles@eccen:~/tmp/git_pr_test/commons-lang$ git diff origin
diff --git a/src/main/java/org/apache/commons/lang3/time/DateUtils.java 
b/src/main/java/org/apache/commons/lang3/time/DateUtils.java
index 2ae637b..7be8c74 100644
--- a/src/main/java/org/apache/commons/lang3/time/DateUtils.java
+++ b/src/main/java/org/apache/commons/lang3/time/DateUtils.java
@@ -613,7 +613,7 @@ public static Date setSeconds(final Date date, final int 
amount) {
 
     //-----------------------------------------------------------------------
     /**
-     * Sets the miliseconds field to a date returning a new object.
+     * Sets the milliseconds field to a date returning a new object.
      * The original {@code Date} is unchanged.
      *
      * @param date  the date, not null
{noformat}

It was a breeze: running {{git pull ...}} and then {{git push}} is all it must 
take to import a contribution.


> Additions to Complex Utils; creation of conversion methods between Complex[], 
> double[], float[], and interleaved arrays
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: MATH-1290
>                 URL: https://issues.apache.org/jira/browse/MATH-1290
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.5
>            Reporter: Eric Barnhill
>            Priority: Minor
>              Labels: newbie, patch
>             Fix For: 4.0
>
>         Attachments: ComplexUtils.java, ComplexUtils.java, ComplexUtils.java, 
> ComplexUtils.java, ComplexUtilsTest.java, ComplexUtilsTest.java, 
> ComplexUtilsTest.java, ComplexUtilsTest.java, LaguerreSolver.java
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> I propose to add several new methods to the ComplexUtils class enabling easy 
> conversion between Complex[] arrays, real or imaginary double[] or float[] 
> arrays, and interleaved complex double[] or float[] arrays. The last two in 
> particular are beneficial to have for OpenCL implementations and the 
> JTransforms library.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to