[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036053#comment-16036053
]
Gilles commented on NUMBERS-38:
-------------------------------
Amey,
Thanks for taking this on.
However, the main interest here is not so much about coverage (that code is
called by other classes in the package) as it is to ensure that this particular
function produces the right values within some known tolerance.
Please correct me if I'm wrong, but it seems that your patch uses values
computed by the same code it is supposed to check.
We should resort to that only when there is no better alternative, which is
usually to compare with the results of another ("reference") library.
For example, you could execute a slightly modified version of the code found
[here|https://en.wikipedia.org/wiki/Lanczos_approximation] to get
independently computed values.
> No unit tests for "LanczosApproximation" class
> ----------------------------------------------
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
> Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
