[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036261#comment-16036261
]
Gilles commented on NUMBERS-38:
-------------------------------
Hi Amey,
Great that you could dig deeper into the review.
With all the information you have gathered, could you set up (separate) unit
tests that highlight every problem?
As you suggest, the first one would be to verify the correlation between gamma
and factorial.
Another thing to check in priority is whether I made some mistake when
copying/refactoring the code coming from "Commons Math".
> No unit tests for "LanczosApproximation" class
> ----------------------------------------------
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
> Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
