[
https://issues.apache.org/jira/browse/NUMBERS-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036289#comment-16036289
]
Amey Jadiye commented on NUMBERS-38:
------------------------------------
bq. I'm now confused as to what the problem is.
Sorry for confusion, there is no bug in output as whole class but I strongly
feel there is incorrect design _(which I called bug)_.
bq. The refactoring was based on the simple premise that each building block is
defined in its own class.
I think that's what not present in code, leading me to generated incorrect
output verses expected according to class. (*misnomer*)
bq. If the output of Gamma is buggy, please file a JIRA report and then create
a corresponding unit test.
No need to raise as bug, but yes different JIRA should be there for
refactoring it correctly.
bq. Why couldn't you generate a list of reference output values, from any of
the codes you've found.
reference functions given are as whole, I can generate by breaking that code
but that's incorrect.
Please review attached patch, you will be more clear on my views.
> No unit tests for "LanczosApproximation" class
> ----------------------------------------------
>
> Key: NUMBERS-38
> URL: https://issues.apache.org/jira/browse/NUMBERS-38
> Project: Commons Numbers
> Issue Type: Test
> Reporter: Gilles
> Labels: unit-test
> Fix For: 1.0
>
> Attachments: NUMBERS-38.patch
>
>
> The computation of the {{LanczosApproximation}} (package
> {{o.a.c.numbers.gamma}} in module {{commons-numbers-gamma}}) function is not
> checked by unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
