[ 
https://issues.apache.org/jira/browse/GEOMETRY-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761810#comment-16761810
 ] 

Gilles commented on GEOMETRY-41:
--------------------------------

I find it strange to have an {{areEqual}} method in {{DoublePrecisionContext}} 
whereas all other similar methods use {{is}} (in this case, perhaps even better 
would be to follow the JDK and use {{equals}}).
I should have spotted it in GEOMETRY-11. :-(

> Vector Precision Equals
> -----------------------
>
>                 Key: GEOMETRY-41
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-41
>             Project: Apache Commons Geometry
>          Issue Type: New Feature
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{Vector?D}} classes should expose {{equals}} method overloads that allow 
> a precision object from GEOMETRY-11 to be passed in to determine equality. I 
> propose adding the following two methods:
>  1. {{boolean equals(Vector?D vec, DoublePrecisionContext precision)}}
>  2. {{boolean isZero(DoublePrecisionContext precision)}}
>  
> Pull request: https://github.com/apache/commons-geometry/pull/24



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to