[
https://issues.apache.org/jira/browse/GEOMETRY-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762579#comment-16762579
]
Gilles commented on GEOMETRY-41:
--------------------------------
I still don't get why {{areEqual}} rather than {{isEqual}} (similar to
{{isLessThan}}).
I get the intention of the "syntactic sugar" methods, but the names are not
well fitted for use in a utility class; e.g.
{code:java}
precision.isLessThanOrEqual(a, b);
{code}
is not significantly clearer, nor shorter, than
{code:java}
precision.compare(a, b) <= 0;
{code}
to warrant the additional method IMO.
> Vector Precision Equals
> -----------------------
>
> Key: GEOMETRY-41
> URL: https://issues.apache.org/jira/browse/GEOMETRY-41
> Project: Apache Commons Geometry
> Issue Type: New Feature
> Reporter: Matt Juntunen
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{Vector?D}} classes should expose {{equals}} method overloads that allow
> a precision object from GEOMETRY-11 to be passed in to determine equality. I
> propose adding the following two methods:
> 1. {{boolean equals(Vector?D vec, DoublePrecisionContext precision)}}
> 2. {{boolean isZero(DoublePrecisionContext precision)}}
>
> Pull request: https://github.com/apache/commons-geometry/pull/24
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
