[ 
https://issues.apache.org/jira/browse/GEOMETRY-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762637#comment-16762637
 ] 

Matt Juntunen commented on GEOMETRY-41:
---------------------------------------

{quote}I still don't get why {{areEqual}} rather than {{isEqual}}
{quote}
 No real reason. That's just how I would say it in a sentence. I can easily 
make the switch.
{quote}is not significantly clearer, nor shorter
{quote}
It's definitely not shorter but I do think it's clearer. For me, it's just one 
less mental step in parsing what the code is doing. What do the think of using 
the C++-ish terse method names like {{eq}}, and {{lte}}? I would definitely be 
ok with using those.

> Vector Precision Equals
> -----------------------
>
>                 Key: GEOMETRY-41
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-41
>             Project: Apache Commons Geometry
>          Issue Type: New Feature
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The {{Vector?D}} classes should expose {{equals}} method overloads that allow 
> a precision object from GEOMETRY-11 to be passed in to determine equality. I 
> propose adding the following two methods:
>  1. {{boolean equals(Vector?D vec, DoublePrecisionContext precision)}}
>  2. {{boolean isZero(DoublePrecisionContext precision)}}
>  
> Pull request: https://github.com/apache/commons-geometry/pull/24



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to